Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a max slippage of 0.5% for Maya and Thor #1427

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Add a max slippage of 0.5% for Maya and Thor #1427

merged 1 commit into from
Dec 2, 2024

Conversation

aminsato
Copy link
Contributor

@aminsato aminsato commented Nov 30, 2024 •
edited
Loading

Fixes #1408

@aminsato aminsato force-pushed the fix/max-slippage branch 2 times, most recently from 2083385 to 3754175 Compare November 30, 2024 16:20
@aminsato aminsato requested a review from yvebe December 2, 2024 05:38
yvebe
yvebe requested changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@yvebe yvebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait a minute, are you sure 5000 bps is 0.5% and not 50%? ain't basic point are from 0 to 10000?

@aminsato
Copy link
Contributor Author

aminsato commented Dec 2, 2024

wait a minute, are you sure 5000 bps is 0.5% and not 50%? ain't basic point are from 0 to 10000?

You are right, thank you for catching that! I’ve corrected it

@aminsato aminsato requested a review from yvebe December 2, 2024 11:18
@yvebe yvebe merged commit bda29ba into main Dec 2, 2024
1 check passed
@yvebe yvebe deleted the fix/max-slippage branch December 2, 2024 12:31
johnnyluo added a commit that referenced this pull request Dec 9, 2024
@johnnyluo
Revert "Add a max slippage of 0.5% (#1427)"
1a0a264 
This reverts commit bda29ba.
@johnnyluo johnnyluo mentioned this pull request Dec 9, 2024
Merged
johnnyluo added a commit that referenced this pull request Dec 9, 2024
@johnnyluo
Revert "Add a max slippage of 0.5% (#1427)" (#1468)
c58efb4 
This reverts commit bda29ba.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yvebe yvebe yvebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADD] Max slippage for Lifi/1inch swaps
2 participants
@aminsato @yvebe